Skip to content

Conversation

@bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 18, 2025

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Dec 18, 2025
Copilot AI review requested due to automatic review settings December 18, 2025 15:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the local push notification reliability by implementing automatic reconnection logic with exponential backoff and extensive diagnostic logging. The changes aim to handle network disruptions more gracefully by detecting when local push becomes unavailable and automatically attempting to re-establish the connection.

Key changes:

  • Adds automatic reconnection mechanism with backoff delays (5s, 10s, 30s) when local push connections fail
  • Introduces comprehensive verbose logging throughout the local push infrastructure for better debugging
  • Refactors manager configuration code into smaller, well-documented helper methods

Copy link
Contributor

Copilot AI commented Dec 22, 2025

@bgoncal I've opened a new pull request, #4132, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Dec 22, 2025

@bgoncal I've opened a new pull request, #4133, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Dec 22, 2025

@bgoncal I've opened a new pull request, #4134, to work on those changes. Once the pull request is ready, I'll request review from you.

bgoncal and others added 2 commits December 22, 2025 12:27
…eExtension.swift

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

⚠️ Unused L10n strings detected

Found 1 unused localization strings in the codebase.

Click to see details
Parsing Strings.swift...
Found 1274 L10n strings

Reading all Swift source code...
Read 4745148 characters of Swift code

Checking for unused strings...
Checked 100/1274 strings...
Checked 200/1274 strings...
Checked 300/1274 strings...
Checked 400/1274 strings...
Checked 500/1274 strings...
Checked 600/1274 strings...
Checked 700/1274 strings...
Checked 800/1274 strings...
Checked 900/1274 strings...
Checked 1000/1274 strings...
Checked 1100/1274 strings...
Checked 1200/1274 strings...

================================================================================
UNUSED STRINGS REPORT
================================================================================

Found 1 unused strings:


WATCH:
  - L10n.Watch.Labels.noAction
    Key: watch.labels.no_action
    Line: 3913

================================================================================
Total unused: 1
================================================================================

To clean up these strings, manually remove them from the Localizable.strings files
and regenerate Strings.swift using SwiftGen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants