-
Notifications
You must be signed in to change notification settings - Fork 403
Improve local push reliability and reconnection #4113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the local push notification reliability by implementing automatic reconnection logic with exponential backoff and extensive diagnostic logging. The changes aim to handle network disruptions more gracefully by detecting when local push becomes unavailable and automatically attempting to re-establish the connection.
Key changes:
- Adds automatic reconnection mechanism with backoff delays (5s, 10s, 30s) when local push connections fail
- Introduces comprehensive verbose logging throughout the local push infrastructure for better debugging
- Refactors manager configuration code into smaller, well-documented helper methods
Sources/App/Notifications/NotificationManagerLocalPushInterfaceExtension.swift
Show resolved
Hide resolved
Sources/App/Notifications/NotificationManagerLocalPushInterfaceExtension.swift
Show resolved
Hide resolved
Sources/App/Notifications/NotificationManagerLocalPushInterfaceExtension.swift
Show resolved
Hide resolved
Sources/App/Notifications/NotificationManagerLocalPushInterfaceExtension.swift
Outdated
Show resolved
Hide resolved
Sources/App/Notifications/NotificationManagerLocalPushInterfaceExtension.swift
Show resolved
Hide resolved
…eExtension.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Found 1 unused localization strings in the codebase. Click to see detailsTo clean up these strings, manually remove them from the |
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes