Fix local push reconnection logic to prevent stalled reconnections #4134
+34
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The reconnection logic had a critical bug where failed reconnection attempts would not schedule subsequent retries, causing local push to permanently fail until app restart. Additionally, rapid status updates could schedule duplicate timers with incorrect backoff timing.
Root cause:
scheduleReconnection()was only called when a server was first added todisconnectedServers. After the first reconnection attempt failed, subsequent status checks found the server already tracked and did nothing, breaking the reconnection chain.Changes:
scheduleReconnection()→scheduleReconnectionIfNeeded()with idempotency guardsscheduleReconnectionIfNeeded()for unavailable states (not just initial disconnection)Flow before fix:
Flow after fix:
Screenshots
N/A - Internal networking logic change
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
This PR merges into #4113 and addresses feedback from review comment #4113 (comment).
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.