Rename live activity webhook types to drop mobile_app_ prefix#4585
Draft
rwarner wants to merge 2 commits into
Draft
Rename live activity webhook types to drop mobile_app_ prefix#4585rwarner wants to merge 2 commits into
rwarner wants to merge 2 commits into
Conversation
7 tasks
Aligns with home-assistant/core#166072 where the webhook handlers were renamed from mobile_app_live_activity_token/dismissed to live_activity_token/dismissed to match the naming convention of all other webhooks in the mobile_app integration (none of which carry the prefix). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rwarner
force-pushed
the
fix/live-activity-webhook-names
branch
from
d59a7ff to
4faadd4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the Live Activity webhook type strings sent from the iOS app to Home Assistant so they follow the existing mobile_app integration convention (short names without the mobile_app_ prefix).
Changes:
- Update
LiveActivityRegistry.webhookTypeTokento"live_activity_token". - Update
LiveActivityRegistry.webhookTypeDismissedto"live_activity_dismissed".
Follows the rename in LiveActivityRegistry.swift from mobile_app_live_activity_* to live_activity_* to stay consistent with HA core's webhook naming convention. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4585 +/- ##
=======================================
Coverage ? 43.24%
=======================================
Files ? 275
Lines ? 16700
Branches ? 0
=======================================
Hits ? 7222
Misses ? 9478
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bgoncal
approved these changes
Apr 29, 2026
Member
bgoncal
left a comment
bgoncal
left a comment
There was a problem hiding this comment.
Let's wait for the other PRs to merge it in sync this time
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webhookTypeTokenfrom"mobile_app_live_activity_token"→"live_activity_token"webhookTypeDismissedfrom"mobile_app_live_activity_dismissed"→"live_activity_dismissed"Requested in home-assistant/core#166072 — all other webhooks in the mobile_app integration use short names without the
mobile_app_prefix (e.g.scan_tag,update_location). This aligns our new webhook types with that convention.Related
🤖 Generated with Claude Code
Part of epic: home-assistant/epics#61
Fixes: #4623