Skip to content

Rename live activity webhook types to drop mobile_app_ prefix #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rwarner wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Draft

Rename live activity webhook types to drop mobile_app_ prefix #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4faadd4
Rename live activity webhook types to drop mobile_app_ prefix
rwarner Apr 29, 2026
9a5e0d1
Update contract tests to match renamed webhook types
rwarner Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Shared/LiveActivity/LiveActivityRegistry.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ public actor LiveActivityRegistry: LiveActivityRegistryProtocol {
// MARK: - Webhook Constants (wire-format frozen — tested in LiveActivityContractTests)

/// Webhook type for reporting a new per-activity push token to HA.
static let webhookTypeToken = "mobile_app_live_activity_token"
static let webhookTypeToken = "live_activity_token"
/// Keys in the token webhook request data dictionary.
static let tokenWebhookKeys: Set<String> = ["activity_id", "push_token", "apns_environment"]

/// Webhook type for reporting that a Live Activity was dismissed.
static let webhookTypeDismissed = "mobile_app_live_activity_dismissed"
static let webhookTypeDismissed = "live_activity_dismissed"
Comment thread
rwarner marked this conversation as resolved.
/// Keys in the dismissed webhook request data dictionary.
static let dismissedWebhookKeys: Set<String> = ["activity_id", "live_activity_tag", "reason"]
Comment thread
rwarner marked this conversation as resolved.

Expand Down
4 changes: 2 additions & 2 deletions Tests/Shared/LiveActivity/LiveActivityContractTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ final class LiveActivityContractTests: XCTestCase {
func testWebhookTypeToken_isFrozen() {
XCTAssertEqual(
LiveActivityRegistry.webhookTypeToken,
"mobile_app_live_activity_token"
"live_activity_token"
)
}

Expand All @@ -108,7 +108,7 @@ final class LiveActivityContractTests: XCTestCase {
func testWebhookTypeDismissed_isFrozen() {
XCTAssertEqual(
LiveActivityRegistry.webhookTypeDismissed,
"mobile_app_live_activity_dismissed"
"live_activity_dismissed"
)
}

Expand Down
Loading