[patch] fix missing parameters #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durera
requested changes
Dec 10, 2025
| value: "{{ kafka_namespace }}" | ||
| - name: kafka_version | ||
| value: "{{ kafka_version }}" | ||
| - name: kafka_storage_class |
Contributor
There was a problem hiding this comment.
we should not introduce new storage class params into the pipeline, we need to map from the two we have (rwo and rwx) into the params of the tasks that need these.
We don't want multiple pipeline params all carrying the same information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the installation on a VPC cluster, it was identified some parameters that weren't correctly mapped and were relying on
getDefaultStorageClass. Therefore, they need to be added in the pipeline to be mappedChanges
grafana_instance_storage_class,kafka_storage_classandgrafana_storage_class.Tests
The test was performed in the a VPC cluster:
