Skip to content

[patch] fix missing parameters #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
terc1997 wants to merge 6 commits into from
Closed

[patch] fix missing parameters #146

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55cd7df
[patch] add support for pvc
terc1997 Nov 28, 2025
c719ab1
[patch] add grafana storage class parameter
terc1997 Dec 3, 2025
d9cdb00
[patch] add kafka and zookeeper storage class parameters
terc1997 Dec 3, 2025
bb582e0
Merge branch 'stable' into mascore-10984
terc1997 Dec 3, 2025
10e0c50
[patch] remove mas devops changes
terc1997 Dec 8, 2025
a4e93e3
Merge branch 'stable' into mascore-10984
terc1997 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/mas/devops/templates/pipelinerun-install.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ spec:
value: "{{ kafka_namespace }}"
- name: kafka_version
value: "{{ kafka_version }}"
- name: kafka_storage_class
Copy link
Contributor

@durera durera Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not introduce new storage class params into the pipeline, we need to map from the two we have (rwo and rwx) into the params of the tasks that need these.

We don't want multiple pipeline params all carrying the same information.

value: "{{ kafka_storage_class }}"
- name: zookeeper_storage_class
value: "{{ zookeeper_storage_class }}"
{%- if kafka_provider == "aws" %}

# Dependencies - AWS MSK
Expand Down Expand Up @@ -732,6 +736,8 @@ spec:
value: "{{ grafana_v5_namespace }}"
- name: grafana_instance_storage_size
value: "{{ grafana_instance_storage_size }}"
- name: grafana_instance_storage_class
value: "{{ grafana_instance_storage_class }}"
{%- endif %}
{%- if mas_app_channel_facilities is defined and mas_app_channel_facilities != "" %}

Expand Down