[TASK] Add checks and tests for GitHub workflows#17
Open
sypets wants to merge 2 commits into
Open
Conversation
Add some checks and tests (in particular php-cs-fixer) which were already defined in composer.json, but some pieces were missing. - remove repository for powermail "pro" from composer.json because it will prevent "composer install" from working without credentials and is not need currently for v12. (Alternatively, the repository could be kept there and removed in th GitHub job using (must add key first in compsoer.json): composer config --unset repositories.powermail_pro - copy .project/tests/.php-cs-fixer.php from powermail repo (v12) - add php-cs-fixer as dev requiredment - copy .github/workflow/testing.yaml from powermail repo (v12) - use .build instead of .Build in scripts (since that is what is being used, also corresponds to powermail) - add phpstan, copy config from powermail - add "fix:php:cs" for fixing cgl - fix some phpstan warnings - add files for testing to .gitattributes (export-ignore)
Author
|
The test run is now successful: https://github.com/sypets/powermail_cleaner/actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional notes: This is a proposal for getting checks via GitHub started. I think for contribution having common cgl styles applied to files would be helpful. The phpstan checks did not find anything problematic (level 5), but might be helpful in the future.
Please feel free to reject and close or request changes.
The php-cs-fixer is currently commented out in .github/workflows/testing.yaml since it will result in several .php files to be change. Can be added later.
Add some checks and tests (in particular php-cs-fixer, phpstan) which were partially already defined in composer.json, but some pieces were missing
composer config --unset repositories.powermail_pro