support transient field, update_display_data#204
Merged
Conversation
minrk
force-pushed
the
update-display-data
branch
from
6f3b0b9 to
f9957b5
Compare
This was referenced Nov 8, 2016
rgbkrk
approved these changes
Nov 8, 2016
Member
|
I've got an initial implementation that I'll start writing tests for in nteract and evaluating the implementation with direct action mocks. Looking forward to trying this out with the IPython kernel. |
Member
|
What do you think the order of merging and shipping this + ipython/ipython#10048 is? |
minrk
changed the title
Member
Author
|
This one can go first, but I'll make sure that IPython behaves gracefully with ipykernel stable, so release order shouldn't matter too much. The main question that's relevant to both is deciding on the new signature for This should be good to go now, in fact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API addition:
DisplayPublisher.publishaccepts two new keyword-args:update: bool, transient: dict(new args, fully backward-compatible).Message spec:
adds third
transientdict next to data, metadata for data that shouldn't be persisted as part of files.display_id will be added to this this transient dict by
display(obj, display_id=...)IPython PR: ipython/ipython#10048
This is the ipykernel piece of jupyter/jupyter_client#209
cc @rgbkrk