Skip to content

make tmp install dir user writable after copytree#377

Closed
ecoughlan wants to merge 1 commit into
ipython:masterfrom
ecoughlan:writable-install-tmp
Closed

make tmp install dir user writable after copytree#377
ecoughlan wants to merge 1 commit into
ipython:masterfrom
ecoughlan:writable-install-tmp

Conversation

@ecoughlan

Copy link
Copy Markdown

When installing if the RESOURCES path is not user writable, installation fails. This happens for instance on NixOS, but it's probably a bad idea to depend on the source modes in any case.

@Mic92

Mic92 commented Dec 12, 2018

Copy link
Copy Markdown

In particular we make packages read-only to avoid the user accidentally writing to the nix storage path, when we run nix in unprivileged mode.

@ivanov

ivanov commented May 15, 2021

Copy link
Copy Markdown
Member

Hey there @Mic92 and @ecoughlan, a very belated thank you for getting involved and making this contribution and using the patch in the nix packaging. I'm going through old issues and it seems to me that it makes sense to close this one. It looks like an equivalent fix was submitted and merged in #593, which made its way into ipykernel 5.5.0. Looks like @FRidh already took out this patch in NixOS/nixpkgs@e3900e3 when upgrading to ipykernel 5.5.0 in the nixpkgs.

Thanks everyone and happy hacking! :bowtie:

@ivanov ivanov closed this May 15, 2021
@ivanov

ivanov commented May 15, 2021

Copy link
Copy Markdown
Member

and again, my sincerest apologies that this went overlooked for so long and a newer fix ended up getting merged instead of yours. Hopefully we'll catch you further down the commit log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants