Skip to content

Removed filtering of stack frames for testing#633

Merged
SylvainCorlay merged 1 commit into
ipython:masterfrom
JohanMabille:debug_osx
Apr 12, 2021
Merged

Removed filtering of stack frames for testing#633
SylvainCorlay merged 1 commit into
ipython:masterfrom
JohanMabille:debug_osx

Conversation

@JohanMabille

Copy link
Copy Markdown
Contributor

Fixes #629

@mlucool can you confirm?

@JohanMabille JohanMabille force-pushed the debug_osx branch 2 times, most recently from 3a9e4b7 to 5e9668f Compare April 12, 2021 14:33
@mlucool

mlucool commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

This works for me - thanks! Will you release a new alpha after as well?

@JohanMabille

Copy link
Copy Markdown
Contributor Author

I don't have the permission for that, but I'm sure we can ask @blink1073 ;) But I need to understand the failure before (although it looks totally unrelated).

@JohanMabille

Copy link
Copy Markdown
Contributor Author

According to @davidbrochart, the failures are due to the last release of Jupyter Client:

for instance get_msg() doesn't have a block kwargs anymore

David is working on a PR to fix the tests, I will rebase when it is merged.

@SylvainCorlay

Copy link
Copy Markdown
Member

Let's tag a release.

@SylvainCorlay

Copy link
Copy Markdown
Member

6.0.0a3 is out with that fix.

@JohanMabille JohanMabille deleted the debug_osx branch April 12, 2021 20:35
@Carreau Carreau added this to the 6.0 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPykernel Debugger

4 participants