Fix local debug builds without signing certificate#12
Open
BradGroux wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the local (Debug) build workflow to avoid requiring an Apple Development signing certificate or the maintainer’s development team, so contributor builds succeed on fresh checkouts.
Changes:
- Add Debug-only
xcodebuildoverrides to disable code signing by default (CODE_SIGNING_ALLOWED=NO). - Allow opting into signed Debug builds via
DEBUG_CODE_SIGNING_ALLOWED=YESandDEBUG_DEVELOPMENT_TEAM=.... - Document the new default and override flags in contributor docs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Adds Debug signing override variables and applies them to the build target so make build works without local signing setup. |
| CONTRIBUTING.md | Documents that Debug builds are unsigned by default and shows how to enable signed Debug builds with Make variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for releasing this!
Summary
This updates the local debug build path so
make buildworks on contributor machines that do not have the maintainer's Apple development team or signing certificate installed.Root cause
The Xcode project has automatic signing configured with the maintainer's development team. That is appropriate for signed app distribution, but it makes the documented contributor command fail on a fresh checkout with:
Changes
make buildandmake dev.CODE_SIGNING_ALLOWED=NO.CONTRIBUTING.md.Contributors who need a signed debug build can still run:
Validation
make buildmake -n releaseCloses #11.