Closed
Conversation
added 7 commits
June 27, 2019 15:32
4 tasks
At consume endpoint we now redirect the user to the exact same path and query params and cookies but to a host that is the same as the target_url. For it to be possible target url must be passed in a cookie that is shared between subdomains. This allows developer to register only one domain at idp but the redirect the user to an appropriate one when they consume.
Don't discard the whole configuration just because of on idp failure and log errors more specifically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is also a PR to open source here. The only difference is the lack of the last commit 6cdba90 and a lack of redirection possibility (a8034b5).