fix(rest): chain firmware gate threw 'json is not defined' when it fired#370
Merged
Conversation
requireChainSupport was defined at server scope but returns via the per-request json() closure (CORS + audit logging), so the moment the firmware gate actually fired — observed on POST /addresses/hive — it threw ReferenceError instead of the intended 501. Latent on the solana/tron/ton routes too. Moved inside the request scope; tsc had been flagging the out-of-scope name all along (rest-api baseline 66 → 65 errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed on latest develop:
[REST] Error on POST /addresses/hive: json is not defined.requireChainSupportwas defined at server scope but returns via the per-requestjson()closure (CORS + audit logging), so whenever the firmware gate actually fired it threwReferenceErrorinstead of the intended 501 with the firmware-requirement message. Latent on every route using the gate (solana/tron/ton/hive) — only visible when a chain's minFirmware check fails.Moved the helper inside the request scope. Proof it was the bug: the rest-api tsc baseline drops 66 → 65 — the out-of-scope
jsonreference had been sitting in the known type-error noise the whole time.