Skip to content

fix(rest): chain firmware gate threw 'json is not defined' when it fired #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BitHighlander merged 1 commit into from
Jul 18, 2026
Merged

fix(rest): chain firmware gate threw 'json is not defined' when it fired #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions projects/keepkey-vault/src/bun/rest-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,16 +1136,6 @@ export function startRestApi(engine: EngineController, auth: AuthStore, port = 1
}

/** Return 501 if firmware doesn't meet the chain's minFirmware requirement. */
function requireChainSupport(chainId: string): Response | null {
const chain = CHAINS.find(c => c.id === chainId)
if (!chain?.minFirmware) return null
const fw = engine.getDeviceState().firmwareVersion
if (!fw || !isChainSupported(chain, fw)) {
return json({ error: `${chain.symbol} requires firmware ≥ ${chain.minFirmware} (device has ${fw ?? 'unknown'})` }, 501)
}
return null
}

/** Normalize showDisplay to boolean (undefined → false). */
function showDisplay(requested: boolean | undefined): boolean {
return requested ?? false
Expand Down Expand Up @@ -1258,6 +1248,20 @@ export function startRestApi(engine: EngineController, auth: AuthStore, port = 1
return resp
}

// Firmware gate for chain routes. Lives INSIDE the request scope because
// it returns via the per-request json() helper (CORS + audit logging) —
// defined at server scope it threw "json is not defined" the moment the
// gate actually fired (observed on POST /addresses/hive).
function requireChainSupport(chainId: string): Response | null {
const chain = CHAINS.find(c => c.id === chainId)
if (!chain?.minFirmware) return null
const fw = engine.getDeviceState().firmwareVersion
if (!fw || !isChainSupported(chain, fw)) {
return json({ error: `${chain.symbol} requires firmware ≥ ${chain.minFirmware} (device has ${fw ?? 'unknown'})` }, 501)
}
return null
}

// ── MCP agent bridge (EPIC_mcp_agent_bridge.md, keepkey-client) ──
// LOOPBACK + LOCAL-AGENT ONLY, handled BEFORE the shared CORS/OPTIONS
// path below so /mcp owns its own preflight and never inherits the
Expand Down