-
Notifications
You must be signed in to change notification settings - Fork 14
feat: add focusedGuideKeys debug setting to pin a guide #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomaswhyyou
merged 9 commits into
main
from
thomas-kno-11802-toolbar-support-focusing-on-a-target-guide
Feb 27, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
722fa20
support focusedGuideKeys in favor of forcedGuideKey
thomaswhyyou e1ae670
add tests
thomaswhyyou 98d7f24
add pin button to control focusedGuideKeys from the toolbar
thomaswhyyou 053551e
respect focusedGuideKeys in selectGuide while in debug mode
thomaswhyyou a9ce8f8
add tests
thomaswhyyou 6ede049
add placeholder buttons
thomaswhyyou 8e198f5
priortitize focused guide keys ahead of forced guide key
thomaswhyyou 728cb65
more style touch up
thomaswhyyou 88597c7
add todo comments
thomaswhyyou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,10 +14,7 @@ export const GuideContextDetails = () => { | |
| const { defaultGroup, debugSettings } = useStore(client.store, (state) => { | ||
| return { | ||
| defaultGroup: state.guideGroups[0], | ||
| debugSettings: { | ||
| skipEngagementTracking: !!state.debug?.skipEngagementTracking, | ||
| ignoreDisplayInterval: !!state.debug?.ignoreDisplayInterval, | ||
| }, | ||
| debugSettings: state.debug || {}, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just use the whole debug object to make life simpler. |
||
| }; | ||
| }); | ||
| const displayInterval = defaultGroup?.display_interval ?? null; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.