Skip to content

feat: add focusedGuideKeys debug setting to pin a guide#879

Merged
thomaswhyyou merged 9 commits intomainfrom
thomas-kno-11802-toolbar-support-focusing-on-a-target-guide
Feb 27, 2026
Merged

feat: add focusedGuideKeys debug setting to pin a guide#879
thomaswhyyou merged 9 commits intomainfrom
thomas-kno-11802-toolbar-support-focusing-on-a-target-guide

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 25, 2026

Description

  • Adds a focusedGuideKeys debug setting to the guide client, an object to hold guide keys to "focus" while in debug mode
    • Note, this effectively replaces the existing forcedGuideKey debug setting - with one difference being that focusedGuideKeys can hold more than one guide keys. For now we still limit to one guide key in the toolbar UI layer, but I wanted to make this change now in case we need to come back to extend this for useGuides (i.e. force rendering multiple guides with useGuides)
    • The plan is to clean up and remove forcedGuideKey after toolbar v2 ships.
  • Adds a couple placeholder buttons so Krisna can take them into account for design refresh. Will come back in separate PRs to make them functional.

Screenshots or videos

CleanShot.2026-02-26.at.16.44.00.mp4

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 27, 2026 7:18pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 27, 2026 7:18pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 27, 2026 7:18pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 27, 2026 7:18pm

Request Review

@linear
Copy link

linear bot commented Feb 25, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

⚠️ No Changeset found

Latest commit: 88597c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

thomaswhyyou commented Feb 25, 2026

@thomaswhyyou
Copy link
Contributor Author

@cursor review

@thomaswhyyou
Copy link
Contributor Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

<Box w="full">
{result.error && <Box>{result.error}</Box>}
<GuideContextDetails />
{result.error && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, a minor style touch up.

skipEngagementTracking: !!state.debug?.skipEngagementTracking,
ignoreDisplayInterval: !!state.debug?.ignoreDisplayInterval,
},
debugSettings: state.debug || {},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use the whole debug object to make life simpler.

@thomaswhyyou thomaswhyyou requested review from a team, MikeCarbone, andy-knock and connorlindsey and removed request for a team February 26, 2026 21:55
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 26.08696% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.65%. Comparing base (68d94b7) to head (88597c7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 2.70% 36 Missing ⚠️
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 11.11% 16 Missing ⚠️
packages/client/src/clients/guide/client.ts 68.96% 9 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 14.28% 6 Missing ⚠️
...uide/components/Toolbar/V2/GuideContextDetails.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   67.00%   66.65%   -0.36%     
==========================================
  Files         205      205              
  Lines        8948     9032      +84     
  Branches     1193     1201       +8     
==========================================
+ Hits         5996     6020      +24     
- Misses       2928     2988      +60     
  Partials       24       24              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
...uide/components/Toolbar/V2/GuideContextDetails.tsx 6.52% <0.00%> (+0.13%) ⬆️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 15.23% <14.28%> (+0.08%) ⬆️
packages/client/src/clients/guide/client.ts 89.43% <68.96%> (-0.44%) ⬇️
...les/guide/components/Toolbar/V2/GuideHoverCard.tsx 10.76% <11.11%> (+0.13%) ⬆️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 7.31% <2.70%> (-1.28%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants