feat: add skipEngagementTracking debug setting to guide toolbar#877
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| default: | ||
| return undefined; | ||
| guide: KnockGuide, |
There was a problem hiding this comment.
Minor refactor to take guide's archived_at timestamp into consideration, along with a "mark_as_archived" marker.
To be clear, the backend should always return a "mark_as_archived" ineligibility marker for any guide that has been marked as archived previously. But now that we provide a toolbar setting to limit engagement actions to the client side only without sending engagement events to the API, we need to look at guides' engagement timestamps in the client state also.
thomaswhyyou
force-pushed
the
thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default
branch
from
a5c05aa to
027ac6b
Compare
| "@popperjs/core": "^2.11.8", | ||
| "@radix-ui/react-dialog": "^1.1.15", | ||
| "@radix-ui/react-hover-card": "^1.1.15", | ||
| "@telegraph/button": "^0.4.0", |
There was a problem hiding this comment.
Not a new dep. We already use buttons in the react package, but never explicitly listed it as a dep.
|
@cursor review |
thomaswhyyou
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| case "guide_not_active": | ||
| return { | ||
| active: { | ||
| status: false, |
There was a problem hiding this comment.
Empty steps guide incorrectly marked archived
Low Severity
Guides with zero steps are incorrectly marked as archived because [].every(...) returns true in JavaScript (vacuous truth). The intent is to mark a guide archived when all steps have archived_at; a guide with no steps has nothing to archive and should not be considered archived.
There was a problem hiding this comment.
This is fine, guides should always have one step at the moment.
thomaswhyyou
requested review from
andy-knock,
connorlindsey and
kylemcd
and removed request for
a team
thomaswhyyou
deleted the
thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default
branch
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
- Coverage 67.34% 67.19% -0.15%
==========================================
Files 205 205
Lines 8855 8917 +62
Branches 1183 1191 +8
==========================================
+ Hits 5963 5992 +29
- Misses 2868 2901 +33
Partials 24 24
|
2 participants
Description
Adds an
skipEngagementTrackingdebug setting to the guide client and in the toolbar.By default it's turned ON when opening the toolbar and going into debug mode. When turned on, we limit engagement updates to the client side store state only, without hitting the API. This is so you can interact/dismiss and walk through guides without having to reset each guide's status to go back.
Linear: https://linear.app/knock/issue/KNO-11772/toolbar-setting-to-intercept-engagement-actions-while-previewing
Screenshots or videos