Skip to content

feat: add ignoreDisplayInterval debug setting to guide toolbar#878

Merged
thomaswhyyou merged 5 commits intomainfrom
thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2
Feb 27, 2026
Merged

feat: add ignoreDisplayInterval debug setting to guide toolbar#878
thomaswhyyou merged 5 commits intomainfrom
thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 25, 2026

Description

Adds an ignoreDisplayInterval debug setting to the guide client and in the toolbar.

By default it's turned ON when opening the toolbar and going into debug mode. When turned on, we ignore the current throttle setting and immediately show the next guide. This is so that you can walk through guides quickly for debugging, without having to wait between each guide.

Screenshots or videos

CleanShot 2026-02-25 at 15 16 17@2x

@linear
Copy link

linear bot commented Feb 25, 2026

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 27, 2026 6:20pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 27, 2026 6:20pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 27, 2026 6:20pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 27, 2026 6:20pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

⚠️ No Changeset found

Latest commit: d229d76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

thomaswhyyou commented Feb 25, 2026

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2 branch from 2bc9f81 to 18a6fe8 Compare February 25, 2026 20:17
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2 branch from 18a6fe8 to ee40242 Compare February 25, 2026 20:29
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default branch from a5c05aa to 027ac6b Compare February 25, 2026 20:39
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2 branch from ee40242 to 8b38f62 Compare February 25, 2026 20:39
@thomaswhyyou thomaswhyyou changed the title add ignoreDisplayInterval debug setting feat: add ignoreDisplayInterval debug setting to guide toolbar Feb 25, 2026
@thomaswhyyou
Copy link
Contributor Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2 branch from 8b38f62 to 6a8548b Compare February 25, 2026 21:02
Base automatically changed from thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default to main February 27, 2026 18:15
@thomaswhyyou thomaswhyyou requested a review from a team as a code owner February 27, 2026 18:15
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2 branch from 6a8548b to d229d76 Compare February 27, 2026 18:18
@thomaswhyyou thomaswhyyou merged commit 68d94b7 into main Feb 27, 2026
12 of 13 checks passed
@thomaswhyyou thomaswhyyou deleted the thomas-kno-11771-toolbar-setting-to-ignore-throttling-while-debugging-default-2 branch February 27, 2026 19:04
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.00%. Comparing base (84357ad) to head (d229d76).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...uide/components/Toolbar/V2/GuideContextDetails.tsx 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   66.99%   67.00%   +0.01%     
==========================================
  Files         205      205              
  Lines        8950     8948       -2     
  Branches     1191     1193       +2     
==========================================
  Hits         5996     5996              
+ Misses       2934     2928       -6     
- Partials       20       24       +4     
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 89.86% <100.00%> (+0.01%) ⬆️
packages/client/src/clients/guide/helpers.ts 93.66% <100.00%> (+0.13%) ⬆️
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
...uide/components/Toolbar/V2/GuideContextDetails.tsx 6.38% <0.00%> (-1.52%) ⬇️

... and 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants