:sparkles: Add Podman support by Karthik-K-N · Pull Request #157 · kubernetes-sigs/node-readiness-controller

Karthik-K-N · 2026-03-09T08:04:14Z

Description

Add support for Podman

Related Issue

Type of Change

/kind feature

Testing

Checklist

make test passes
make lint passes

Does this PR introduce a user-facing change?

Add Podman support

Doc #(issue)

netlify · 2026-03-09T08:04:20Z

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	`01d8525`
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/69b23d8f6b54cb000886170c

Karthik-K-N · 2026-03-09T08:11:26Z

/cc @Priyankasaggu11929

Priyankasaggu11929 · 2026-03-09T14:32:57Z

Makefile

@@ -177,7 +181,11 @@ run: manifests generate fmt vet ## Run a controller from your host.
 # More info: https://docs.docker.com/develop/develop-images/build_enhancements/
 .PHONY: docker-build
 docker-build: ## Build docker image with the manager.


Suggested change

docker-build: ## Build docker image with the manager.

container-build: ## Build docker image with the manager.

docker-build for building with podman feels a bit confusing

Yeah, Correct, I just update it. Thanks.

I understood docker-build as more of a standard target name in Make due to conventions.

Not to sound prudent, and this may be fine to make such changes as we are still in early releases -- but I think we should be careful about changing existing names / fields as it may be breaking change for users.

In that case should I keep the docker build target, Only specific to building docker.

I think I'm okay with either- using a variable override or a podman-target

Added separate target for docker and podman. Please take a look. Thanks.

Priyankasaggu11929 · 2026-03-09T14:33:56Z

Makefile

 .PHONY: docker-build-reporter
 docker-build-reporter: ## Build docker image with the reporter.


Suggested change

.PHONY: docker-build-reporter

docker-build-reporter: ## Build docker image with the reporter.

.PHONY: container-build-reporter

container-build-reporter: ## Build container image with the reporter.

Priyankasaggu11929 · 2026-03-09T14:58:00Z

docs/TEST_README.md

+**Verify the image is loaded:**
+```bash
+# Check images in the Kind cluster
+docker exec -it nrr-test-control-plane crictl images | grep controller


we add a podman exec ... version too, since we have a podman variant for all other commands above

Sure, Done.

Priyankasaggu11929 · 2026-03-09T14:58:34Z

docs/TEST_README.md


+**Using Podman:**
+```bash
+make deploy IMG_PREFIX=localhost/controller IMG_TAG=latest


TIL, that podman forces the localhost prefix.

Yes, Thats correct.

Priyankasaggu11929 · 2026-03-09T14:59:29Z

changes looks good to me. (I tested as well locally)

ajaysundark · 2026-03-09T17:02:48Z

@Karthik-K-N I think you need to change the usage across all tests too.

Karthik-K-N · 2026-03-09T17:07:51Z

@Karthik-K-N I think you need to change the usage across all tests too.

I just updated the e2e test to use the contaienr-build, but the podman support is not yet available in e2e tests, I hope thats fine for now? or should I add it now itself.

.dockerignore

ajaysundark · 2026-03-12T04:21:59Z

/lgtm
/approve

k8s-ci-robot · 2026-03-12T04:22:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark, Karthik-K-N

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ajaysundark]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2026

k8s-ci-robot requested review from SergeyKanzhelev and tallclair March 9, 2026 08:04

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2026

Karthik-K-N force-pushed the podman-support branch from 9dc39b6 to b1e4475 Compare March 9, 2026 08:09

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2026

k8s-ci-robot requested a review from Priyankasaggu11929 March 9, 2026 08:11

Priyankasaggu11929 reviewed Mar 9, 2026

View reviewed changes

Karthik-K-N force-pushed the podman-support branch from 424e2d9 to f09274e Compare March 9, 2026 15:09

Add podman support

ba8bd79

Karthik-K-N force-pushed the podman-support branch from f09274e to ba8bd79 Compare March 9, 2026 17:03

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2026

Karthik-K-N force-pushed the podman-support branch from 9e169b3 to 1ebb28c Compare March 11, 2026 16:12

ajaysundark reviewed Mar 12, 2026

View reviewed changes

.dockerignore Show resolved Hide resolved

Seperate out docker-build and podman-build to avoid breaking change

01d8525

Karthik-K-N force-pushed the podman-support branch from 1ebb28c to 01d8525 Compare March 12, 2026 04:14

k8s-ci-robot assigned ajaysundark Mar 12, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026

k8s-ci-robot merged commit c206921 into kubernetes-sigs:main Mar 12, 2026
10 checks passed

	docker-build: ## Build docker image with the manager.
	container-build: ## Build docker image with the manager.

		.PHONY: docker-build-reporter
		docker-build-reporter: ## Build docker image with the reporter.

Conversation

Karthik-K-N commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Testing

Checklist

Does this PR introduce a user-facing change?

Uh oh!

netlify bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for node-readiness-controller canceled.

Uh oh!

Karthik-K-N commented Mar 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 commented Mar 9, 2026

Uh oh!

ajaysundark commented Mar 9, 2026

Uh oh!

Karthik-K-N commented Mar 9, 2026

Uh oh!

Uh oh!

ajaysundark commented Mar 12, 2026

Uh oh!

k8s-ci-robot commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Karthik-K-N commented Mar 9, 2026 •

edited

Loading

netlify bot commented Mar 9, 2026 •

edited

Loading