generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 25
✨ Add Podman support #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 2 commits into
kubernetes-sigs:main
from
Karthik-K-N:podman-support
Mar 12, 2026
+98
−20
Merged
✨ Add Podman support #157
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,36 @@ | ||
| # More info: https://docs.docker.com/engine/reference/builder/#dockerignore-file | ||
| # Ignore everything by default and re-include only needed files | ||
| ** | ||
| # Compatible with both Docker and Podman | ||
| # Use explicit exclusions (not negation patterns) for better compatibility | ||
|
|
||
| # Re-include Go source files (but not *_test.go) | ||
| !**/*.go | ||
| # Build artifacts and unnecessary files | ||
| bin/ | ||
| dist/ | ||
| .git/ | ||
| .github/ | ||
| docs/ | ||
| examples/ | ||
| hack/ | ||
| test/ | ||
| *.md | ||
| *.tape | ||
| *.gif | ||
| *.mp4 | ||
| *.svg | ||
| *.png | ||
|
|
||
| # Test files | ||
| **/*_test.go | ||
|
|
||
| # Re-include Go module files | ||
| !go.mod | ||
| !go.sum | ||
| # Cache directories | ||
| .cache/ | ||
|
|
||
| # IDE and editor files | ||
| .vscode/ | ||
| .idea/ | ||
| *.swp | ||
| *.swo | ||
| *~ | ||
|
|
||
| # OS files | ||
| .DS_Store | ||
| Thumbs.db | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ The test uses a 3-node Kind cluster: | |
|
|
||
| ### Prerequisites | ||
|
|
||
| - [Docker](https://docs.docker.com/get-docker/) | ||
| - [Docker](https://docs.docker.com/get-docker/) or [Podman](https://podman.io/getting-started/installation) | ||
| - [Kind](https://kind.sigs.k8s.io/docs/user/quick-start/#installation) | ||
| - [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | ||
| - [Go](https://golang.org/doc/install) | ||
|
|
@@ -38,21 +38,44 @@ make install | |
|
|
||
| Build the controller image and load it into the Kind cluster nodes. | ||
|
|
||
| **Using Docker:** | ||
| ```bash | ||
| # Build the image | ||
| make docker-build IMG_PREFIX=controller IMG_TAG=latest | ||
| # Build the image (uses defaults: IMG_PREFIX=controller IMG_TAG=latest) | ||
| make docker-build | ||
|
|
||
| # Load the image into the kind cluster | ||
| kind load docker-image controller:latest --name nrr-test | ||
| # Load the image into the kind cluster (uses default: KIND_CLUSTER=nrr-test) | ||
| make kind-load | ||
|
|
||
| # Verify the image is loaded | ||
| docker exec -it nrr-test-control-plane crictl images | grep controller | ||
| ``` | ||
|
|
||
| **Using Podman:** | ||
| ```bash | ||
| # Build the image (uses defaults: IMG_PREFIX=controller IMG_TAG=latest) | ||
| make podman-build | ||
|
|
||
| # Load the image into the kind cluster (uses default: KIND_CLUSTER=nrr-test) | ||
| make kind-load CONTAINER_TOOL=podman | ||
|
|
||
| # Verify the image is loaded | ||
| podman exec -it nrr-test-control-plane crictl images | grep controller | ||
| ``` | ||
|
|
||
| ### Step 3: Controller Deployment | ||
|
|
||
| Deploy the controller image to nrr-test-worker | ||
| Deploy the controller to the cluster. | ||
|
|
||
| **Using Docker:** | ||
| ```bash | ||
| make deploy IMG_PREFIX=controller IMG_TAG=latest | ||
| ``` | ||
|
|
||
| **Using Podman:** | ||
| ```bash | ||
| make deploy IMG_PREFIX=localhost/controller IMG_TAG=latest | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TIL, that podman forces the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, Thats correct. |
||
| ``` | ||
|
|
||
| Verify the controller is running on the control plane node (`nrr-test-control-plane`): | ||
| ```bash | ||
| kubectl get pods -n nrr-system -o wide | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.