[quality] Fix card-config deep schema test to accept componentName alias by clubanderson · Pull Request #20560 · kubestellar/console

clubanderson · 2026-07-08T06:02:44Z

Test Improvement

Fixes the custom content has component name assertion in card-config-deep-schema.test.ts which was failing for all newer card configs that use componentName instead of component.

The UnifiedCardConfig type (line 255-257 of types.ts) defines both:

componentName?: string — primary field
component?: string — alias for componentName

The test only checked content.component, missing cards that use the canonical componentName field. This caused mass failures across cilium_status, gpu_overview, cascade_impact_map, cluster_delta_detector, config_drift_heatmap, resource_imbalance_detector, right_size_advisor, restart_correlation_matrix, and many others.

Fix: Check for either component OR componentName (matching the type's documented alias pattern).

Fixes #20552

Filed by quality agent (ACMM L4/L6 — full mode)

The UnifiedCardConfig type defines both `component` and `componentName` as valid fields for custom content (componentName is the primary, component is the alias). Newer card configs use `componentName` while older ones use `component`. The test only checked for `component`, causing failures on all newer cards. Fixes #20552 Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

kubestellar-prow · 2026-07-08T06:02:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-07-08T06:02:49Z

✅ Deploy Preview for kubestellarconsole canceled.

Name	Link
🔨 Latest commit	`e0d14d2`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a4dfbf77048d500077e7362

github-actions · 2026-07-08T06:02:52Z

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

github-actions · 2026-07-08T06:02:53Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

Copilot

Pull request overview

This PR updates the deep schema test for card configs to recognize the newer componentName field for custom card content (while still supporting the legacy component alias), aligning the assertion with the CardContentCustom type in web/src/lib/unified/types.ts.

Changes:

Update the “custom content has component name” test to accept either content.component or content.componentName for custom card content.

+        const content = c.content as { type: 'custom'; component?: string; componentName?: string }
+        const name = content.component || content.componentName
+        expect(typeof name).toBe('string')


github-actions · 2026-07-08T06:25:17Z

❌ Playwright Tests Failed

📊 View Full Report

Download the playwright-report artifact from the workflow run for screenshots and detailed traces.

To view the report locally:

# Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report

Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>

github-actions · 2026-07-08T09:26:19Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-07-08T09:27:06Z

⏹️ Post-Merge Verification: cancelled

Commit: 061d2d1e1bc0cf611e116affaf33c72802169262
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/28932169879

github-actions · 2026-07-08T09:32:15Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 061d2d1e1bc0cf611e116affaf33c72802169262.

Copilot AI review requested due to automatic review settings July 8, 2026 06:02

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jul 8, 2026

github-actions Bot added the ai-generated Pull request generated by AI label Jul 8, 2026

kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2026

github-actions Bot added the tier/1-lightweight label Jul 8, 2026

Copilot started reviewing on behalf of clubanderson July 8, 2026 06:03 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread web/src/config/cards/__tests__/card-config-deep-schema.test.ts

Comment on lines +154 to +156

const content = c.content as { type: 'custom'; component?: string; componentName?: string }

const name = content.component || content.componentName

expect(typeof name).toBe('string')

This was referenced Jul 8, 2026

[scanner] fix: quality test failures — mission-control launchProgress mock (#20553) #20565

Merged

[quality] Fix card-config deep schema validation failures (missing component_name) #20552

Closed

[scanner] fix: retrigger CI after flaky OAuth E2E test (PR #20560)

e0d14d2

Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>

kubestellar-hive Bot merged commit 061d2d1 into main Jul 8, 2026
37 of 40 checks passed

kubestellar-prow Bot deleted the quality/test-fix-card-config-schema branch July 8, 2026 09:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[quality] Fix card-config deep schema test to accept componentName alias#20560

[quality] Fix card-config deep schema test to accept componentName alias#20560
kubestellar-hive[bot] merged 2 commits into
mainfrom
quality/test-fix-card-config-schema

clubanderson commented Jul 8, 2026

Uh oh!

kubestellar-prow Bot commented Jul 8, 2026

Uh oh!

netlify Bot commented Jul 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

clubanderson commented Jul 8, 2026

Test Improvement

Uh oh!

kubestellar-prow Bot commented Jul 8, 2026

Uh oh!

netlify Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole canceled.

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jul 8, 2026

❌ Playwright Tests Failed

📊 View Full Report

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

⏹️ Post-Merge Verification: cancelled

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Jul 8, 2026 •

edited

Loading