fix: Android SR, remove visible scrollbars#371
Open
abelonogov-ld wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match current iOS padding approach to remove scrollbars
How did you test this change?
Are there any deployment considerations?
Probably there is more stable way, but this one works
Note
Low Risk
Small, localized change to session replay event generation; main risk is slight coordinate/layout mismatch if consumers assume unpadded dimensions.
Overview
Adds a fixed
RRWEB_DOCUMENT_PADDINGinSessionReplayEventGeneratorand applies it to RRWeb meta sizing and touch coordinates.METAevents now reportwidth/heightwith extra padding, and interaction events (ACTION_DOWN/MOVE/UP) offsetx/yby the same amount so replays align with the padded document and avoid visible scrollbars.Written by Cursor Bugbot for commit 366da92. This will update automatically on new commits. Configure here.