Skip to content

fix: Android SR, remove visible scrollbars #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelonogov-ld merged 1 commit into from
Feb 17, 2026
Merged

fix: Android SR, remove visible scrollbars #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions ...main/kotlin/com/launchdarkly/observability/replay/exporter/SessionReplayEventGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ import kotlinx.serialization.json.put
class SessionReplayEventGenerator(
private val canvasDrawEntourage: Int
) {
companion object {
private const val RRWEB_DOCUMENT_PADDING = 11
}

/**
* Sequence ID for the events being generated.
* Each event in a session needs a unique, monotonically increasing "sid".
Expand Down Expand Up @@ -86,9 +90,9 @@ class SessionReplayEventGenerator(
sid = nextSid(),
data = EventDataUnion.StandardEventData(
EventData(
width = captureEvent.origWidth,
height = captureEvent.origHeight,
)
width = captureEvent.origWidth + RRWEB_DOCUMENT_PADDING * 2,
height = captureEvent.origHeight + RRWEB_DOCUMENT_PADDING * 2,
)
),
)
eventBatch.add(metaEvent)
Expand Down Expand Up @@ -182,7 +186,7 @@ class SessionReplayEventGenerator(
timestamp = firstPosition.timestamp,
sid = nextSid(),
data = EventDataUnion.CustomEventDataWrapper(
Json.parseToJsonElement("""{"source":2,"texts": [],"type":7,"id":6,"x":${firstPosition.x}, "y":${firstPosition.y}}""")
Json.parseToJsonElement("""{"source":2,"texts": [],"type":7,"id":6,"x":${firstPosition.x + RRWEB_DOCUMENT_PADDING}, "y":${firstPosition.y + RRWEB_DOCUMENT_PADDING}}""")
)
)
)
Expand All @@ -206,7 +210,7 @@ class SessionReplayEventGenerator(
timestamp = lastPosition.timestamp,
sid = nextSid(),
data = EventDataUnion.CustomEventDataWrapper(
Json.parseToJsonElement("""{"source":2,"texts": [],"type":9,"id":6,"x":${lastPosition.x}, "y":${lastPosition.y}}""")
Json.parseToJsonElement("""{"source":2,"texts": [],"type":9,"id":6,"x":${lastPosition.x + RRWEB_DOCUMENT_PADDING}, "y":${lastPosition.y + RRWEB_DOCUMENT_PADDING}}""")
)
)
)
Expand All @@ -221,7 +225,7 @@ class SessionReplayEventGenerator(
timestamp = position.timestamp,
sid = nextSid(),
data = EventDataUnion.CustomEventDataWrapper(
Json.parseToJsonElement("""{"positions": [{"id":6,"timeOffset":0,"x":${position.x},"y":${position.y}}], "source": 6}""")
Json.parseToJsonElement("""{"positions": [{"id":6,"timeOffset":0,"x":${position.x + RRWEB_DOCUMENT_PADDING},"y":${position.y + RRWEB_DOCUMENT_PADDING}}], "source": 6}""")
)
)
)
Expand Down
Loading