Added sound menu + cleanup

[ldominiq]

No description provided.

[Copilot]

Pull request overview

This PR introduces a dedicated Sounds settings screen alongside existing Settings/Graphics/Controls menus, wiring it into the main menu flow so players can adjust audio volumes at runtime.

Changes:

• Added a new SoundsMenu UI with sliders (master/music/effects) and a Done button.
• Extended SettingsMenu with a Sounds button and callback to open the new menu.
• Integrated the new menu into App (creation, resize handling, escape/back navigation, cleanup) and adjusted the default musicVolume.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/client/menus/SoundsMenu.cpp	New menu implementation for rendering and interacting with volume sliders.
include/client/menus/SoundsMenu.hpp	New menu interface and slider APIs.
src/client/menus/SettingsMenu.cpp	Adds Sounds button layout/render/hover/click handling.
include/client/menus/SettingsMenu.hpp	Adds setSoundsCallback and stores callback/button state.
src/client/App.cpp	Creates soundsMenu, adds volume sliders, routes Settings→Sounds and Escape/back behavior, handles resize/cleanup.
include/client/App.hpp	Adds soundsMenu member and include.
src/client/AudioManager.cpp	Removes several loadSfx(...) entries during asset preload.
include/client/AudioManager.hpp	Changes default musicVolume from 0.0f to 0.8f.

Comments suppressed due to low confidence (1)

src/client/AudioManager.cpp:289

• SoundId::Player_Jump is still played in updateFootsteps() (jump edge), but loadAllAssets() no longer loads any asset for that id. As a result, jump SFX will be silent at runtime. Please restore the loadSfx(SoundId::Player_Jump, ...) call (or remove the playback if the sound is being deprecated).

    loadSfx(SoundId::Player_Splash,      {
        "assets/sounds/liquids/splash.wav",
        "assets/sounds/liquids/splash2.wav",
        });

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud