Skip to content

Added sound menu + cleanup#106

Merged
ldominiq merged 2 commits into
devfrom
soundMenu
May 22, 2026
Merged

Added sound menu + cleanup#106
ldominiq merged 2 commits into
devfrom
soundMenu

Refactoring

8668c42
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 22, 2026 in 40s

Annotations

Check warning on line 65 in src/client/menus/SoundsMenu.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one.

See more on https://sonarcloud.io/project/issues?id=ldominiq_ft_minecraft&issues=AZ5QM4qK380suO_5NNnz&open=AZ5QM4qK380suO_5NNnz&pullRequest=106

Check warning on line 72 in src/client/menus/SoundsMenu.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=ldominiq_ft_minecraft&issues=AZ5QM4qK380suO_5NNn0&open=AZ5QM4qK380suO_5NNn0&pullRequest=106

Check warning on line 290 in src/client/menus/Menu.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view".

See more on https://sonarcloud.io/project/issues?id=ldominiq_ft_minecraft&issues=AZ5QUWeUoI4Cm-ZmQSOm&open=AZ5QUWeUoI4Cm-ZmQSOm&pullRequest=106

Check warning on line 306 in src/client/menus/Menu.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this const reference to "std::string" by a "std::string_view".

See more on https://sonarcloud.io/project/issues?id=ldominiq_ft_minecraft&issues=AZ5QUWeUoI4Cm-ZmQSOn&open=AZ5QUWeUoI4Cm-ZmQSOn&pullRequest=106

Check warning on line 51 in src/client/menus/SoundsMenu.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=ldominiq_ft_minecraft&issues=AZ5QM4qK380suO_5NNny&open=AZ5QM4qK380suO_5NNny&pullRequest=106