fix: notify LSP client when worker process crashes#12736
Open
wvhulle wants to merge 1 commit intoleanprover:masterfrom
Open
fix: notify LSP client when worker process crashes#12736wvhulle wants to merge 1 commit intoleanprover:masterfrom
wvhulle wants to merge 1 commit intoleanprover:masterfrom
Conversation
This PR sends a `window/showMessage` notification to the LSP client when a file worker process crashes so the editor can display a visible error instead of silently failing.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Author
|
The message of the bot is not clear to me. I have rebased onto the branch mentioned but the bot still shows the message @WojciechKarpiel @mhuisi . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that LSP clients are currently never notified if a panics occurs in the LSP servers file worker.