Skip to content

fix: notify LSP client when worker process crashes #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wvhulle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: notify LSP client when worker process crashes #12736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Lean/Server/Watchdog.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,9 +1540,12 @@ section MainLoop
(ErrorCode.workerExited, "see stderr for exception")
else
(ErrorCode.workerCrashed, "likely due to a stack overflow or a bug")
errorPendingRequests uri errorCode
s!"Server process for {uri} crashed, {errorCausePointer}."
let crashMsg := s!"Server process for {uri} crashed, {errorCausePointer}."
errorPendingRequests uri errorCode crashMsg
writeMessage <| mkFileProgressAtPosNotification doc 0 (kind := LeanFileProgressKind.fatalError)
writeMessage <| (⟨"window/showMessage",
{ type := MessageType.error, message := crashMsg : ShowMessageParams }⟩ :
JsonRpc.Notification ShowMessageParams)
setWorkerState fw .crashed
mainLoop clientTask
| WorkerEvent.terminated =>
Expand Down
Loading