PettingZoo multi-agent RL example cleaned up - #252
Open
ryanlindeborg wants to merge 4 commits into
Open
Conversation
lebrice
requested changes
Nov 10, 2021
lebrice
left a comment
lebrice
left a comment
Owner
There was a problem hiding this comment.
Great! Left a few comments, let me know if you need any help.
lebrice
requested changes
Nov 10, 2021
lebrice
reviewed
Dec 13, 2021
lebrice
requested changes
Dec 13, 2021
lebrice
left a comment
lebrice
left a comment
Owner
There was a problem hiding this comment.
Getting really really close, thanks a bunch!
lebrice
requested changes
Jan 6, 2022
lebrice
left a comment
lebrice
left a comment
Owner
There was a problem hiding this comment.
I'm ready to approve this, but there's just one last thing that's bothering me, it's the env.env.env.env.(...) somewhere!
|
|
||
| class MARLSB3Wrapper(SB3VecEnvWrapper): | ||
| def __init__(self, env): | ||
| super().__init__(env.env.env.env.env.env.env.venv) |
Owner
There was a problem hiding this comment.
Ouch! :P
Getting the venv attribute doesn't work?
If not, then maybe some kind of while loop, like:
while not isinstance(env, WhateverYouWant) and hasattr(env, "env"):
env = env.envLet's chat soon, I'd like to better understand what's going on here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.