feat(gui): carry reset credit expiration onto dev2-go (#613) - #664
Conversation
* feat(gui): show reset credit expiration time * fix(gui): respect selected locale for credit dates (cherry picked from commit f492f7d)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b103d0cf4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <span>{t("codexAuth.creditGranted", { date: formatCreditDate(grantedAt) })}</span> | ||
| <span className={urgent ? "credit-urgent" : ""}>{t("codexAuth.creditExpires", { date: formatCreditDate(expiresAt), days: String(days) })}</span> | ||
| <span>{t("codexAuth.creditGranted", { date: formatCreditDate(grantedAt, locale) })}</span> | ||
| <span className={urgent ? "credit-urgent" : ""}>{t("codexAuth.creditExpires", { date: formatCreditDateTime(expiresAt, locale), days: String(days) })}</span> |
There was a problem hiding this comment.
On this dev2-go port, the new expiration-time rendering exists only in gui/src: the commit does not update go/internal/server/static or static-manifest.json, even though go/internal/server/static.go embeds that committed copy. I checked the Verify embedded GUI bundle step in .github/workflows/go-ci.yml, which runs bun scripts/embed-gui.ts --check; it will report stale assets, and a packaged Go runtime would continue serving the old date-only UI. Run bun scripts/embed-gui.ts and commit its generated outputs, or retarget this source-only GUI change to dev.
AGENTS.md reference: AGENTS.md:L86-L89
Useful? React with 👍 / 👎.
2 participants
Summary
dev2-go(GUI + tests).f492f7d4ondev.Go port
No Go counterpart — GUI-only change (
gui/formatters/components). Decision recorded here per Transition rule.