-
Notifications
You must be signed in to change notification settings - Fork 482
feat(gui): carry reset credit expiration onto dev2-go (#613) #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+74
−17
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { describe, expect, test } from "bun:test"; | ||
| import { formatCreditDate, formatCreditDateTime } from "../src/intl-formatters"; | ||
|
|
||
| describe("credit date formatting", () => { | ||
| test("keeps the compact date format for grant dates", () => { | ||
| const iso = "2026-07-31T12:34:56Z"; | ||
| const time = new Intl.DateTimeFormat("de-DE", { hour: "2-digit", minute: "2-digit" }).format(new Date(iso)); | ||
|
|
||
| expect(formatCreditDate(iso, "de-DE")).not.toContain(time); | ||
| }); | ||
|
|
||
| test("includes the local time for expiration dates", () => { | ||
| const iso = "2026-07-31T12:34:56Z"; | ||
|
|
||
| const time = new Intl.DateTimeFormat("de-DE", { hour: "2-digit", minute: "2-digit" }).format(new Date(iso)); | ||
|
|
||
| expect(formatCreditDateTime(iso, "de-DE")).toContain(time); | ||
| expect(formatCreditDateTime(iso, "de-DE")).not.toBe("—"); | ||
| }); | ||
|
|
||
| test("handles invalid dates consistently", () => { | ||
| expect(formatCreditDateTime("invalid")).toBe("—"); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this
dev2-goport, the new expiration-time rendering exists only ingui/src: the commit does not updatego/internal/server/staticorstatic-manifest.json, even thoughgo/internal/server/static.goembeds that committed copy. I checked theVerify embedded GUI bundlestep in.github/workflows/go-ci.yml, which runsbun scripts/embed-gui.ts --check; it will report stale assets, and a packaged Go runtime would continue serving the old date-only UI. Runbun scripts/embed-gui.tsand commit its generated outputs, or retarget this source-only GUI change todev.AGENTS.md reference: AGENTS.md:L86-L89
Useful? React with 👍 / 👎.