Move bidi algorithm into parley_core - #647
Merged
Merged
Conversation
Member
Author
|
I've posed a question about how exactly we want to go about merging these PRs in #634 (comment). |
DJMcNab
approved these changes
Jun 24, 2026
Member
There was a problem hiding this comment.
I think we should move the conversation about how we land this to Zulip, but this pr on its own is good to land (with awareness that we'll potentially need to reconsider what is pub later)
Reading this PR makes me really want to refactor/clean-up/better document the bidi.rs file. The current documentation of input/output types is really far from ideal.
Member
Author
I agree! Wrote here: #parley > parley_core PR sprint? @ 💬. |
tomcur
added a commit
to tomcur/parley
that referenced
this pull request
Jun 27, 2026
) On top of linebender#647. Temporarily removes `#[non_exhaustive]` from `LineBreakContext` to allow `parley` to construct it (becomes `non_exhaustive` again once the next PR lands).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kicking off the sequence to end up at (roughly) the shape of #634.
Instead of starting with
parley_data, I figured to first move the bidi algorithm as it wires up theparleyandparley_corecrates plus handles some lints thatparleysuppressed andparley_coredoesn't.Two more PRs are ready: first, simply moving the line break opportunity overrides introduced in #640 (similarly moving files and handling lints), second and more interestingly, migrating
parley's analysis without any real changes intoparley_coreand introducingparley_core::{Analysis, Analyzer}.