Skip to content

node version updated from 18 to 22.x on github workflows and Dockerfile#2341

Merged
pwilczynskiclearcode merged 1 commit intomasterfrom
ci-node-update
Oct 28, 2025
Merged

node version updated from 18 to 22.x on github workflows and Dockerfile#2341
pwilczynskiclearcode merged 1 commit intomasterfrom
ci-node-update

Conversation

@pwilczynskiclearcode
Copy link
Contributor

@pwilczynskiclearcode pwilczynskiclearcode commented Oct 21, 2025

Following up #2338

@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
livepeer-studio Ready Ready Preview Comment Oct 21, 2025 0:49am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@pwilczynskiclearcode pwilczynskiclearcode requested a review from a team as a code owner October 21, 2025 12:45
@pwilczynskiclearcode pwilczynskiclearcode changed the title node version updated from 18 to 22.x on github workflows node version updated from 18 to 22.x on github workflows and Dockerfile Oct 21, 2025
@pwilczynskiclearcode pwilczynskiclearcode enabled auto-merge (squash) October 21, 2025 14:24
Copy link
Contributor

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing ty thought i'd need to do this myself 😅

cc @junhyr @gioelecerati the "node bump" you made recently has left the master branch broken for over a month now. I now need to do some urgent changes to fix production issues we are having and am hitting this broken repository that was left behind. Please avoid doing so in the future and only consider the work done after you get a clean build on the main branch.

@pwilczynskiclearcode pwilczynskiclearcode merged commit 38dd561 into master Oct 28, 2025
8 checks passed
@pwilczynskiclearcode pwilczynskiclearcode deleted the ci-node-update branch October 28, 2025 20:28
@pwilczynskiclearcode
Copy link
Contributor Author

pwilczynskiclearcode commented Oct 29, 2025

@victorges @junhyr
Tests of /beta/generate/llm has started to fail with HTTP 422 Unprocessable Content response

FAIL src/controllers/generate.test.ts (6.477 s)
   controllers/generate  generate route  should call the AI Gateway for generate API /llm

    expect(received).toBe(expected) // Object.is equality

    Expected: 200
    Received: 422

      250 |         body: buildForm({ prompt: "foo" }),
      251 |       });
    > 252 |       expect(res.status).toBe(200);
          |                          ^
      253 |       expect(await res.json()).toEqual({
      254 |         message: "success",
      255 |         reqContentType: expect.stringMatching("^multipart/form-data"),

      at Object.toBe (src/controllers/generate.test.ts:252:26)

   controllers/generate  beta generate route  should call the AI Gateway for generate API /llm

    expect(received).toBe(expected) // Object.is equality

    Expected: 200
    Received: 422

      250 |         body: buildForm({ prompt: "foo" }),
      251 |       });
    > 252 |       expect(res.status).toBe(200);
          |                          ^
      253 |       expect(await res.json()).toEqual({
      254 |         message: "success",
      255 |         reqContentType: expect.stringMatching("^multipart/form-data"),

      at Object.toBe (src/controllers/generate.test.ts:252:26)


Test Suites: 1 failed, 35 passed, 36 total
Tests:       2 failed, 495 passed, 497 total
Snapshots:   0 total
Time:        115.407 s
Jest did not exit one second after the test run has completed.

@victorges
Copy link
Contributor

Thanks @pwilczynskiclearcode . This is because of the changes I made on the ai handlers. Not critical as I'm just matching the breaking changes made in the batch AI APIs, but I'll fix them today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants