Skip to content

node version updated from 18 to 22.x on github workflows and Dockerfile #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pwilczynskiclearcode merged 1 commit into from
Oct 28, 2025
Merged

node version updated from 18 to 22.x on github workflows and Dockerfile #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ jobs:
# for ref value discussion
ref: ${{ github.event.pull_request.head.sha }}

- uses: actions/setup-node@v3
- uses: actions/setup-node@v6
with:
node-version: "18"
node-version: "22.x"
cache: "yarn"

- name: Tags
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ jobs:
# for ref value discussion
ref: ${{ github.event.pull_request.head.sha }}

- uses: actions/setup-node@v3
- uses: actions/setup-node@v6
with:
node-version: "18"
node-version: "22.x"
cache: "yarn"

- name: yarn install
Expand Down
4 changes: 2 additions & 2 deletions packages/api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18 as builder
FROM node:22 as builder

Check warning on line 1 in packages/api/Dockerfile

View workflow job for this annotation

GitHub Actions / api builds

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

WORKDIR /app
COPY . .
Expand All @@ -7,15 +7,15 @@
RUN cd packages/www && yarn run static
RUN cd packages/api && yarn run esbuild

FROM node:18
FROM node:22

WORKDIR app

Check warning on line 12 in packages/api/Dockerfile

View workflow job for this annotation

GitHub Actions / api builds

Relative workdir without an absolute workdir declared within the build can have unexpected results if the base image changes 

WorkdirRelativePath: Relative workdir "app" can have unexpected results if the base image changes
More info: https://docs.docker.com/go/dockerfile/rule/workdir-relative-path/
COPY --from=builder /app/packages/api/dist-esbuild/livepeer-api /usr/local/bin/livepeer-api
ENV NODE_ENV production

Check warning on line 14 in packages/api/Dockerfile

View workflow job for this annotation

GitHub Actions / api builds

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ARG VERSION
ENV VERSION ${VERSION}

Check warning on line 16 in packages/api/Dockerfile

View workflow job for this annotation

GitHub Actions / api builds

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ARG GITHUB_SHA
ENV GITHUB_SHA ${GITHUB_SHA}

Check warning on line 18 in packages/api/Dockerfile

View workflow job for this annotation

GitHub Actions / api builds

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV LP_API_PORT 80

Check warning on line 19 in packages/api/Dockerfile

View workflow job for this annotation

GitHub Actions / api builds

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
RUN /usr/local/bin/livepeer-api --help
ENTRYPOINT ["/usr/local/bin/livepeer-api"]
Loading