[Do not merge] Hip wrapper#1266
Draft
scheibelp wants to merge 20 commits into
Draft
Conversation
…to cmake-based parent packages
… the compiler (delegates to rocm clang)
…rapper; this is testing something of a hack to make use of it to do all the rpath insertion we want, but into an invocation of the hip compiler
Collaborator
|
running pipeline https://lc.llnl.gov/gitlab/benchpark/benchpark/-/pipelines/670432 |
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1266 +/- ##
========================================
Coverage 64.18% 64.18%
========================================
Files 49 49
Lines 3767 3767
Branches 324 324
========================================
Hits 2418 2418
Misses 1335 1335
Partials 14 14 🚀 New features to boost your workflow:
|
Collaborator
|
@scheibelp Do we still need this PR or will it be superseded? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a mechanism to perform spack compiler wrapper modifications to hip compiler invocations. Right now, depends on packages explicitly shelling out to an artificial
hip-wrapperpackage. That can potentially be hidden from users.