CI runs the app-target tests; retire the dead LoggingPill - #21
Merged
Conversation
The entire app-side test net — the group-capture E2E suite against the demo fleet, history grouping, foreign-log decisions, export filenames — was invisible to CI, which ran only the SPM suites. New app-tests job runs MetaWearAppTests on an iOS 26 simulator (the app's floor), on the newer runner image that carries Xcode 26. LoggingPill was mounted nowhere (its removal is documented in RootView) and filtered on the pre-multi-device activeDeviceID — deleted, and the three comments that still described it as live now reference the real surfaces (pending-log badges, the Logging screen's status row). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up hygiene from the group-logging cycle. Merge after #19 (this branch stacks on it).
app-testsjob: the app-side test net (group-capture E2E against the demo fleet, history grouping, foreign-log decisions, export filenames — ~70 tests) was invisible to CI, which only ran the SPM suites. RunsMetaWearAppTestson an iPhone 17 simulator on themacos-26image (the app's iOS 26 floor needs Xcode 26). If the runner image's simulator roster differs, the job will say so plainly on its first run and the destination is a one-line tweak.LoggingPilldeleted: mounted nowhere, filtered on pre-multi-device state; the three comments that still described it as live now name the real surfaces.Verified locally: full app suite + SPM suites green with the exact CI invocation.
🤖 Generated with Claude Code