Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,26 @@
name: CI
on: [pull_request]
permissions:
contents: read
jobs:
build-and-test:
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- run: swift build --build-tests
- run: swift test --filter MetaWearTests # skip hardware tests in CI
# The app target's unit tests (coordinator E2E against the demo fleet,
# history grouping, foreign-log decisions, …) were invisible to CI —
# only the SPM suites ran. The app requires the iOS 26 SDK, hence the
# newer runner image.
app-tests:
runs-on: macos-26
steps:
- uses: actions/checkout@v4
- run: >
xcodebuild test
-project Apps/MetaWear/MetaWearApp.xcodeproj
-scheme MetaWearApp
-destination 'platform=iOS Simulator,name=iPhone 17'
-only-testing:MetaWearAppTests
CODE_SIGNING_ALLOWED=NO
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
4 changes: 2 additions & 2 deletions Apps/MetaWear/MetaWear/App/RootView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ private struct ErrorAndOrphanAlerts: ViewModifier {
// so the user can decide what to do with it. The alert only
// fires when LOG_LENGTH > 0 *and* we have no matching local
// pending session — the in-app logging flow has its own UI
// for sessions it already knows about (LoggingPill,
// DownloadView).
// for sessions it already knows about (the Logging
// screen's status row, DownloadView).
.alert(
"Logging in progress",
isPresented: Binding(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ struct LogSessionView: View {
Task {
await viewModel?.start(selections)
// Refresh the AppStore's pending-sessions cache so the
// global `LoggingPill` becomes visible immediately.
// pending-log badges appear immediately.
appStore.refreshPendingLogSessions()
}
}
Expand Down
53 changes: 0 additions & 53 deletions Apps/MetaWear/MetaWear/Features/Logging/LoggingPill.swift

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ final class LogSessionViewModel {
// Per-record try/catch — a single failed `stopOne` (BLE hiccup,
// unexpected board state) used to abort the loop, leaving the
// remaining records' `status` stuck at `.running` and the global
// `LoggingPill` ticking forever. We always flip the status to
// pending-log badges stuck forever. We always flip the status to
// `.stopped` even when the BLE command threw, because:
// - the user explicitly asked the session to stop, and
// - the captured data is still on the board for download.
Expand Down
Loading