fix(webhook): preserve data.id case in signature manifest#372
Open
danielalfarourrea wants to merge 2 commits into
Open
fix(webhook): preserve data.id case in signature manifest#372danielalfarourrea wants to merge 2 commits into
danielalfarourrea wants to merge 2 commits into
Conversation
The manifest was lowercasing dataId before computing the HMAC, but MercadoPago signs the notification using the original casing. This caused signature validation to fail whenever data.id contained uppercase letters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WebhookSignatureValidator.validatewas calling.toLowerCase()ondataIdbefore building the HMAC manifest. MercadoPago signs webhook notifications using the original casing ofdata.id, so any notification with uppercase or mixed-case identifiers would fail validation withSignatureMismatch.Fix
Remove the
.toLowerCase()call inbuildManifestso the value is included exactly as received. The Javadoc is updated accordingly.Testing
Verified manually with
data.idvalues in uppercase (ORDER123), lowercase (order123), and mixed case (oRdEr) — all pass when the signature was generated with the same casing.