Skip to content

fix(webhook): preserve data.id case in signature manifest #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielalfarourrea wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(webhook): preserve data.id case in signature manifest #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0881465
fix(webhook): preserve data.id case in signature manifest
danielalfarourrea Jun 17, 2026
617bf63
test(webhook): update test to reflect case-preserving data.id behavior
danielalfarourrea Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/mercadopago/webhook/WebhookSignatureValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ private WebhookSignatureValidator() {
* manifest before computing the HMAC
* @param dataId value of the {@code data.id} query parameter; may be {@code null} or
* blank, in which case the {@code id:} pair is omitted. When present,
* it is lowercased before being included in the manifest
* it is included in the manifest exactly as received
* @param secret secret signature configured for the application in Tus Integraciones,
* used as the HMAC key
* @throws MPInvalidWebhookSignatureException when the signature is missing, malformed, or
Expand Down Expand Up @@ -201,7 +201,7 @@ private static ParsedSignature parseSignatureHeader(String header) {
private static String buildManifest(String dataId, String requestId, String timestamp) {
StringBuilder sb = new StringBuilder();
if (dataId != null) {
sb.append("id:").append(dataId.toLowerCase()).append(';');
sb.append("id:").append(dataId).append(';');
}
if (requestId != null) {
sb.append("request-id:").append(requestId).append(';');
Expand Down
7 changes: 4 additions & 3 deletions src/test/java/com/mercadopago/webhook/WebhookSignatureValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ private static String computeHash(String dataId, String requestId, String ts, St
try {
StringBuilder mb = new StringBuilder();
if (dataId != null && !dataId.isEmpty()) {
mb.append("id:").append(dataId.toLowerCase()).append(';');
mb.append("id:").append(dataId).append(';');
}
if (requestId != null && !requestId.isEmpty()) {
mb.append("request-id:").append(requestId).append(';');
Expand Down Expand Up @@ -68,9 +68,10 @@ void happyPathLowercase() {

// case 2
@Test
void uppercaseDataIdIsLowercased() {
void uppercaseDataIdIsPreserved() {
String upperHash = computeHash(DATA_ID_RAW, REQUEST_ID, TS, SECRET);
assertDoesNotThrow(() ->
WebhookSignatureValidator.validate(buildHeader(validHash()), REQUEST_ID, DATA_ID_RAW, SECRET));
WebhookSignatureValidator.validate(buildHeader(upperHash), REQUEST_ID, DATA_ID_RAW, SECRET));
}

// case 3
Expand Down