Upgrade Node to 24.17.0 and give common-python-lsp standalone Dependabot PRs#684
Merged
Merged
Conversation
…bot PRs - Pin NODE_VERSION to 22.23.0 in pr-check.yml/push-check.yml and .nvmrc - Exclude @vscode/common-python-lsp (npm) and vscode-common-python-lsp (pip) from the weekly grouped updates so they get standalone PRs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
VS Code currently ships Node 24; align CI NODE_VERSION and .nvmrc to 24.17.0. @types/node stays at 22.x. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
changed the title
rchiodo
reviewed
Jun 23, 2026
| @@ -0,0 +1 @@ | |||
| 24.17.0 | |||
Contributor
There was a problem hiding this comment.
📍 .nvmrc:1
This adds a third hardcoded copy of the Node version (.nvmrc, pr-check.yml, push-check.yml) but no CI step reads it — both workflows install via node-version: ${{ env.NODE_VERSION }}, not node-version-file: .nvmrc. The three literals can silently drift, and this conflicts with the repo guidance to read the version from .nvmrc. Prefer pointing actions/setup-node at node-version-file: .nvmrc so the file becomes the real single source of truth; otherwise add a comment clarifying .nvmrc is local-dev-only.
rchiodo
approved these changes
Jun 23, 2026
rchiodo
left a comment
rchiodo
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_VERSIONto24.17.0(latest Node 24 LTS, matching VS Code's bundled runtime) inpr-check.yml/push-check.yml, and set.nvmrcto match.@vscode/common-python-lsp(npm) andvscode-common-python-lsp(pip) from the weekly grouped Dependabot updates so they get their own standalone PRs.@types/nodeis unchanged (22.x). Dependabot schedules remain weekly.