Skip to content

Upgrade Node to 24.17.0 and give common-python-lsp standalone Dependabot PRs #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edvilme merged 2 commits into from
Jun 23, 2026
Merged

Upgrade Node to 24.17.0 and give common-python-lsp standalone Dependabot PRs #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf5313
Upgrade Node to 22.23.0 and give common-python-lsp standalone Dependa…
edvilme Jun 23, 2026
6d74009
Use Node 24.17.0 (latest 24 LTS) to match VS Code's bundled runtime
edvilme Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ updates:
npm-minor-patch:
patterns:
- '*'
# Exclude @vscode/common-python-lsp so it gets its own standalone PR (weekly).
exclude-patterns:
- '@vscode/common-python-lsp'
update-types:
- 'minor'
- 'patch'
Expand All @@ -36,6 +39,9 @@ updates:
pip-minor-patch:
patterns:
- '*'
# Exclude vscode-common-python-lsp so it gets its own standalone PR (weekly).
exclude-patterns:
- 'vscode-common-python-lsp'
update-types:
- 'minor'
- 'patch'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:

env:
NODE_VERSION: 22.21.1
NODE_VERSION: 24.17.0
PYTHON_VERSION: '3.10'
TEST_RESULTS_DIRECTORY: .
# Force a path with spaces and unicode chars to test extension works in these scenarios
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
- 'release-*'

env:
NODE_VERSION: 22.21.1
NODE_VERSION: 24.17.0
PYTHON_VERSION: '3.10'
TEST_RESULTS_DIRECTORY: .
# Force a path with spaces and unicode chars to test extension works in these scenarios
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
24.17.0

@rchiodo rchiodo Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📍 .nvmrc:1
This adds a third hardcoded copy of the Node version (.nvmrc, pr-check.yml, push-check.yml) but no CI step reads it — both workflows install via node-version: ${{ env.NODE_VERSION }}, not node-version-file: .nvmrc. The three literals can silently drift, and this conflicts with the repo guidance to read the version from .nvmrc. Prefer pointing actions/setup-node at node-version-file: .nvmrc so the file becomes the real single source of truth; otherwise add a comment clarifying .nvmrc is local-dev-only.

Loading