Skip to content

Fix chat pickers not opening in auxiliary windows#305047

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/fix-chats-open-pickers
Closed

Fix chat pickers not opening in auxiliary windows#305047
Copilot wants to merge 2 commits intomainfrom
copilot/fix-chats-open-pickers

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

Chat pickers (model, mode, context, etc.) fail to open when a chat editor is in an auxiliary window. The ActionWidgetService.show() always receives undefined for the container parameter, causing ContextViewService to fall back to layoutService.activeContainer — which may not resolve to the correct window at call time.

  • Inject ILayoutService into ActionWidgetService
  • When no explicit container is provided and the anchor is an HTMLElement, derive the container from the anchor's window via layoutService.getContainer(getWindow(anchor))

This ensures the context view is always parented to the same window as the clicked element.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI linked an issue Mar 26, 2026 that may be closed by this pull request
@vs-code-engineering vs-code-engineering bot added this to the 1.114.0 milestone Mar 26, 2026
… window support

When the ActionWidgetService shows a picker without an explicit container,
it now derives the container from the anchor element's window via
ILayoutService.getContainer(). This ensures pickers (model picker, mode
picker, etc.) render in the correct window when used in auxiliary windows,
fixing the issue where chat pickers in new windows failed to open.

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/d6150146-30eb-4c8e-a86d-9417a253dd3e

Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with chats in new windows not opening any pickers Fix chat pickers not opening in auxiliary windows Mar 26, 2026
Copilot AI requested a review from bpasero March 26, 2026 06:18
@bpasero bpasero closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chats in new windows cannot open any pickers

2 participants