Skip to content

Fix chat pickers not opening in auxiliary windows #305047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+10 −1
Closed

Fix chat pickers not opening in auxiliary windows #305047

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0727c80
Initial plan
Copilot Mar 26, 2026
5fe7bd3
fix: derive action widget container from anchor element for auxiliary…
Copilot Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/vs/platform/actionWidget/browser/actionWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { IContextViewService } from '../../contextview/browser/contextView.js';
import { InstantiationType, registerSingleton } from '../../instantiation/common/extensions.js';
import { createDecorator, IInstantiationService, ServicesAccessor } from '../../instantiation/common/instantiation.js';
import { KeybindingWeight } from '../../keybinding/common/keybindingsRegistry.js';
import { ILayoutService } from '../../layout/browser/layoutService.js';
import { inputActiveOptionBackground, registerColor } from '../../theme/common/colorRegistry.js';
import { StandardMouseEvent } from '../../../base/browser/mouseEvent.js';
import { IListAccessibilityProvider } from '../../../base/browser/ui/list/listWidget.js';
Expand Down Expand Up @@ -56,14 +57,22 @@ class ActionWidgetService extends Disposable implements IActionWidgetService {
constructor(
@IContextViewService private readonly _contextViewService: IContextViewService,
@IContextKeyService private readonly _contextKeyService: IContextKeyService,
@IInstantiationService private readonly _instantiationService: IInstantiationService
@IInstantiationService private readonly _instantiationService: IInstantiationService,
@ILayoutService private readonly _layoutService: ILayoutService,
) {
super();
}

show<T>(user: string, supportsPreview: boolean, items: readonly IActionListItem<T>[], delegate: IActionListDelegate<T>, anchor: HTMLElement | StandardMouseEvent | IAnchor, container: HTMLElement | undefined, actionBarActions?: readonly IAction[], accessibilityProvider?: Partial<IListAccessibilityProvider<IActionListItem<T>>>, listOptions?: IActionListOptions): void {
const visibleContext = ActionWidgetContextKeys.Visible.bindTo(this._contextKeyService);

// When no container is specified but the anchor is an HTMLElement,
// derive the container from the anchor's window so that the widget
// renders in the correct window (e.g. auxiliary windows).
if (!container && dom.isHTMLElement(anchor)) {
container = this._layoutService.getContainer(dom.getWindow(anchor));
}

const list = this._instantiationService.createInstance(ActionList, user, supportsPreview, items, delegate, accessibilityProvider, listOptions, anchor);
this._contextViewService.showContextView({
getAnchor: () => anchor,
Expand Down