Respect display language for automatic voice locale - #329016
Draft
meganrogge wants to merge 4 commits into
Draft
Conversation
Fixes microsoft#328854 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b11adb7d-72c1-4e64-ba1e-f798dd9bf490
Contributor
There was a problem hiding this comment.
Pull request overview
Updates automatic on-device dictation to follow VS Code’s display language rather than the browser locale.
Changes:
- Uses
Language.value()when resolving automatic dictation language. - Renames resolver terminology from browser to display language.
- Updates resolver tests for display-language and explicit-setting behavior.
Show a summary per file
| File | Description |
|---|---|
chatSpeechToTextService.ts |
Supplies the active VS Code display language to dictation. |
dictationLanguage.ts |
Updates resolver naming and documentation. |
chatSpeechToTextService.test.ts |
Adjusts language-resolution regression cases. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
meganrogge
marked this pull request as draft
August 4, 2026 18:16
auto-merge was automatically disabled
August 4, 2026 18:16
Pull request was converted to draft
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Preserve configured English display-language precedence while integrating Voice Mode, fallback, documentation, and test updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b11adb7d-72c1-4e64-ba1e-f798dd9bf490
meganrogge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328854
Automatic voice and dictation language selection now follows VS Code's configured display language instead of relying only on the browser or system locale.
agents.voice.languageprecedence.Includes the changes from #329018.