Respect display language for automatic voice locale - #329018
Closed
meganrogge with Copilot wants to merge 2 commits into
Closed
Respect display language for automatic voice locale#329018meganrogge with Copilot wants to merge 2 commits into
meganrogge with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
requested
a balanced review from Copilot
and removed request for
Copilot
August 4, 2026 18:16
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
requested
a balanced review from Copilot
and removed request for
Copilot
August 4, 2026 18:23
Copilot
AI
changed the title
[WIP] Fix code for voice mode locale handling
Respect display language for automatic voice locale
Aug 4, 2026
meganrogge
marked this pull request as ready for review
August 4, 2026 19:10
meganrogge
enabled auto-merge (squash)
August 4, 2026 19:10
meganrogge
approved these changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates automatic voice and dictation locale resolution to prefer VS Code’s display language before browser/system locale.
Changes:
- Adds display-language-first locale resolution for Voice Mode and Nemotron dictation.
- Adds focused locale precedence tests.
- Updates settings descriptions to explain precedence.
Show a summary per file
| File | Description |
|---|---|
voiceClientService.ts |
Resolves automatic Voice Mode language. |
dictationLanguage.ts |
Resolves automatic Nemotron locale. |
voiceClientService.test.ts |
Tests Voice Mode locale precedence. |
chatSpeechToTextService.test.ts |
Tests dictation locale precedence. |
chat.shared.contribution.ts |
Updates Nemotron setting documentation. |
agentsVoice.contribution.ts |
Updates Voice Mode setting documentation. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
Comment on lines
+233
to
+234
| const displayLanguage = Language.isDefaultVariant() ? undefined : Language.value(); | ||
| return resolveAutomaticVoiceLanguage(this._window?.navigator.language, displayLanguage); |
Comment on lines
+55
to
+56
| function getConfiguredDisplayLanguage(): string | undefined { | ||
| return Language.isDefaultVariant() ? undefined : Language.value(); |
meganrogge
added a commit
to meganrogge/vscode
that referenced
this pull request
Aug 4, 2026
Preserve configured English display-language precedence while integrating Voice Mode, fallback, documentation, and test updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b11adb7d-72c1-4e64-ba1e-f798dd9bf490
Collaborator
|
Superseded by #329016, which now includes these changes plus the explicit-English locale fix. |
auto-merge was automatically disabled
August 4, 2026 19:22
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic voice and dictation language selection now accounts for VS Code’s configured display language instead of relying only on the browser/system locale.