Skip to content

Configurable vehicle parameters#13

Open
Cowboylaserkittenjetshark wants to merge 12 commits into
mainfrom
vehicle_config
Open

Configurable vehicle parameters#13
Cowboylaserkittenjetshark wants to merge 12 commits into
mainfrom
vehicle_config

Conversation

@Cowboylaserkittenjetshark
Copy link
Copy Markdown
Member

@Cowboylaserkittenjetshark Cowboylaserkittenjetshark commented Apr 9, 2026

Vehicle parameters related to thrusters, DoF, and PID are hard coded and need to be configurable.

These are complete:

  • Motor matrix
  • Thruster inversions
  • DoF speeds
  • PID values

@Cowboylaserkittenjetshark Cowboylaserkittenjetshark marked this pull request as ready for review April 14, 2026 00:23
Copy link
Copy Markdown

@1upbyte 1upbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not enough factory builders

@SarangaR
Copy link
Copy Markdown
Contributor

LGTM

cabby-cabby-cat-3212669847

SarangaR
SarangaR previously approved these changes Apr 15, 2026
@SarangaR
Copy link
Copy Markdown
Contributor

RESOLVE YO CONFLICTS

@1upbyte
Copy link
Copy Markdown

1upbyte commented Apr 15, 2026

@copilot resolve the merge conflicts in this pull request

Co-authored-by: 1upbyte <55856800+1upbyte@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented Apr 15, 2026

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 25c6160. The conflicts were in Cargo.toml — combined thiserror + color-eyre from this branch with rerun and build/dev-dependencies from main.

Copilot AI requested a review from 1upbyte April 15, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants