Fixed #20950: Add missing module and device properties in module-bay #21005
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kprince28
changed the title
jnovinger
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
reviewed
Dec 18, 2025
| installed_module = ModuleSerializer( | ||
| nested=True, | ||
| fields=('id', 'url', 'display', 'serial', 'description'), | ||
| fields=('id', 'url', 'display', 'device', 'module_bay'), |
Member
There was a problem hiding this comment.
Why did we lose serial and description here?
Contributor
Author
There was a problem hiding this comment.
because I just follow the API specification in this API, so serial and description are not present in the API spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20950