Skip to content

Fixed #20950: Add missing module and device properties in module-bay #21005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kprince28 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fixed #20950: Add missing module and device properties in module-bay #21005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions netbox/dcim/api/serializers_/device_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,14 +350,14 @@ class ModuleBaySerializer(NetBoxModelSerializer):
device = DeviceSerializer(nested=True)
module = ModuleSerializer(
nested=True,
fields=('id', 'url', 'display'),
fields=('id', 'url', 'display', 'device', 'module_bay'),
required=False,
allow_null=True,
default=None
)
installed_module = ModuleSerializer(
nested=True,
fields=('id', 'url', 'display', 'serial', 'description'),
fields=('id', 'url', 'display', 'device', 'module_bay'),
Copy link
Member

@jnovinger jnovinger Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we lose serial and description here?

Copy link
Contributor Author

@kprince28 kprince28 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I just follow the API specification in this API, so serial and description are not present in the API spec.

Copy link
Member

@jnovinger jnovinger Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Unfortunately, removing fields from an API serializer like this is a breaking change that will need to be present in a minor release, as opposed to this, which will ship in a patch release.

It's also very possible that those fields were intended to be there all along and that the OpenAPI schema that's being generated is just incorrect.

Please restore these fields in this PR. We will need to follow up on this in a new issue. If you have a moment, we would very much appreciate if you could file a bug for this.

required=False,
allow_null=True
)
Expand Down
Loading