Skip to content

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 19, 2025

☑️ Resolves

🖼️ Screenshots

Screenshot from 2025-11-19 16-59-49 Screenshot from 2025-11-19 16-59-43

🚧 Tasks

  • Some margin from inputs.scss is applied that creates that small space between the label and the checkbox. This fixes it. I cannot think of any better solution

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD self-assigned this Nov 19, 2025
@GretaD GretaD added bug Something isn't working 3. to review Waiting for reviews labels Nov 19, 2025
@GretaD
Copy link
Contributor Author

GretaD commented Nov 19, 2025

/backport to stable8

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.11%. Comparing base (8e6c2a6) to head (a7896a9).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7890   +/-   ##
=======================================
  Coverage   52.11%   52.11%           
=======================================
  Files         100      100           
  Lines        3170     3170           
  Branches      872      873    +1     
=======================================
  Hits         1652     1652           
  Misses       1271     1271           
  Partials      247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme changed the title fix(NcActionCheckbox: margin around the checkbox fix(NcActionCheckbox): margin around the checkbox Nov 19, 2025
@ShGKme ShGKme added this to the 9.3.0 milestone Nov 19, 2025
@susnux susnux modified the milestones: 9.3.0, 9.3.1 Nov 20, 2025
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is still actual, or you fixed it already in Mail?

&::before {
margin-block: 0 !important;
margin-inline: calc((var(--default-clickable-area) - 14px) / 2) !important;
margin: 9px !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simply overriding two lines above. Doesn't it conflict with other usecases for component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it comes from here, so we should fix it here. I understand that 9px is very random, so maybe i can think about how not to have an exact number like that. Its broken everywhere where we use this component, at least everywhere on mail

@Antreesy Antreesy modified the milestones: 9.3.1, 9.4.0 Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants