-
Notifications
You must be signed in to change notification settings - Fork 95
fix(NcActionCheckbox): margin around the checkbox #7890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: greta <gretadoci@gmail.com>
|
/backport to stable8 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7890 +/- ##
=======================================
Coverage 52.11% 52.11%
=======================================
Files 100 100
Lines 3170 3170
Branches 872 873 +1
=======================================
Hits 1652 1652
Misses 1271 1271
Partials 247 247 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is still actual, or you fixed it already in Mail?
| &::before { | ||
| margin-block: 0 !important; | ||
| margin-inline: calc((var(--default-clickable-area) - 14px) / 2) !important; | ||
| margin: 9px !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This simply overriding two lines above. Doesn't it conflict with other usecases for component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it comes from here, so we should fix it here. I understand that 9px is very random, so maybe i can think about how not to have an exact number like that. Its broken everywhere where we use this component, at least everywhere on mail
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable