Skip to content

fix(NcActionCheckbox): margin around the checkbox #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GretaD wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix(NcActionCheckbox): margin around the checkbox #7890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/NcActionCheckbox/NcActionCheckbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ export default {
&::before {
margin-block: 0 !important;
margin-inline: calc((var(--default-clickable-area) - 14px) / 2) !important;
margin: 9px !important;
Copy link
Contributor

@Antreesy Antreesy Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simply overriding two lines above. Doesn't it conflict with other usecases for component?

Copy link
Contributor Author

@GretaD GretaD Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it comes from here, so we should fix it here. I understand that 9px is very random, so maybe i can think about how not to have an exact number like that. Its broken everywhere where we use this component, at least everywhere on mail

}
}

Expand Down
Loading