fix(tests): scope admin settings heading locator to the guests section - #1645
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
Contributor
Author
|
The test (Playwright) job is green again ✅ Scoping the assertion to the app's own #guest-settings container makes it resolve to exactly one heading (our section Ready for review. 👀 |
1 task
ernolf
enabled auto-merge
July 30, 2026 01:47
miaulalala
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test(Playwright) job has been red onmainand on every PR since around 2026-06-11. It is not caused by any guests change: between the last green run (2026-06-09) and the first red one (2026-06-11) the only commits were a Transifex l10n update and an AUTHORS entry, andadmin-settings.spec.tsitself is unchanged since it was added.The assertion trips Playwright strict mode:
The settings framework renders a visually-hidden page heading
<h1>carrying the active section name ("Guests"), which collides with our own section<h2>. That<h1>is server-side and predates this app; nothing in this repo changed. Thetestjob boots thecontinuous-integration-shallow-serverimage, a shallow clone ofnextcloud/servermaster taken at image build time innextcloud/docker-ci; it was last rebuilt on 2026-06-10 (build) and the first guests run afterwards is the first red one: green 2026-06-09 → red 2026-06-11, red on every run since.This scopes the locator to the app's
#guest-settingscontainer, which is exactly what Playwright's own error output suggests, so it matches only our section heading. No change to app behaviour.🤖 AI (if applicable)
Assisted-by: ClaudeCode:claude-opus-4-8